third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html ('k') | third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

index 2c5150cc7b6c370304e85b1926f8f5734f9dab7c..028ff227ba874df4c70ef505a45283e4f8322d90 100644

--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js

@@ -226,7 +226,8 @@ Accessibility.AXNodeTreeElement = class extends UI.TreeElement {

if (this._preselected) {

this._treePane._setPreselectedTreeElement(this);

this.listItemElement.classList.toggle('hovered', true);

- this._axNode.highlightDOMNode();

+ if (this._axNode.deferredDOMNode())

+ this._axNode.deferredDOMNode().highlight();

}

@@ -241,7 +242,8 @@ Accessibility.AXNodeTreeElement = class extends UI.TreeElement {

if (this._hovered) {

this._treePane.setHoveredElement(this);

this.listItemElement.classList.toggle('hovered', true);

- this._axNode.highlightDOMNode();

+ if (this._axNode.deferredDOMNode())

+ this._axNode.deferredDOMNode().highlight();

}