Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js b/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
index 0e100049c16a94ab2f7b2f6d2a0c12149ac82ab4..63fe1ceb8d4910313f54482ea6e1e1bbd4c8815a 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
@@ -26,7 +26,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/**
- * @implements {SDK.TargetManager.Observer}
+ * @implements {SDK.SDKModelObserver<!SDK.DOMModel>}
* @unrestricted
*/
Elements.InspectElementModeController = class {
@@ -34,27 +34,26 @@ Elements.InspectElementModeController = class {
this._toggleSearchAction = UI.actionRegistry.action('elements.toggle-element-search');
this._mode = Protocol.DOM.InspectMode.None;
SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChanged, this._suspendStateChanged, this);
- SDK.targetManager.observeTargets(this, SDK.Target.Capability.DOM);
+ SDK.targetManager.observeModels(SDK.DOMModel, this);
}
/**
* @override
- * @param {!SDK.Target} target
+ * @param {!SDK.DOMModel} domModel
*/
- targetAdded(target) {
+ modelAdded(domModel) {
// When DevTools are opening in the inspect element mode, the first target comes in
// much later than the InspectorFrontendAPI.enterInspectElementMode event.
if (this._mode === Protocol.DOM.InspectMode.None)
return;
- var domModel = SDK.DOMModel.fromTarget(target);
domModel.setInspectMode(this._mode);
}
/**
* @override
- * @param {!SDK.Target} target
+ * @param {!SDK.DOMModel} domModel
*/
- targetRemoved(target) {
+ modelRemoved(domModel) {
}
/**

Powered by Google App Engine
This is Rietveld 408576698