third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

index cb02ad4d45ce2bb90e42be44ae5a04277e9c6ff9..267faad3f60c85d14521c617137449dc4f5ee416 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

@@ -48,7 +48,7 @@ Resources.ServiceWorkersView = class extends UI.VBox {

if (this._manager)

return;

this._manager = serviceWorkerManager;

- this._securityOriginManager = SDK.SecurityOriginManager.fromTarget(serviceWorkerManager.target());

+ this._securityOriginManager = serviceWorkerManager.target().model(SDK.SecurityOriginManager);

for (var registration of this._manager.registrations().values())

this._updateRegistration(registration);