Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index a33b5dea6d4b93a9706e99b4e10401a8ca6e550e..2babce02bfe6d25941674dfe8d356ff7d59683d5 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -265,8 +265,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
}
showCertificateViewer() {
- var securityModel = Security.SecurityModel.fromTarget(this._target);
- securityModel.showCertificateViewer();
+ this._target.model(Security.SecurityModel).showCertificateViewer();
}
/**
@@ -287,7 +286,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
return;
var listeners = [];
- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
+ var resourceTreeModel = target.model(SDK.ResourceTreeModel);
if (resourceTreeModel) {
listeners = listeners.concat([
resourceTreeModel.addEventListener(
@@ -302,7 +301,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
this._onInterstitialShown();
}
- var networkManager = SDK.NetworkManager.fromTarget(target);
+ var networkManager = target.model(SDK.NetworkManager);
if (networkManager) {
listeners = listeners.concat([
networkManager.addEventListener(SDK.NetworkManager.Events.ResponseReceived, this._onResponseReceived, this),
@@ -310,7 +309,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
]);
}
- var securityModel = Security.SecurityModel.fromTarget(target);
+ var securityModel = target.model(Security.SecurityModel);
if (securityModel) {
listeners = listeners.concat([securityModel.addEventListener(
Security.SecurityModel.Events.SecurityStateChanged, this._onSecurityStateChanged, this)]);

Powered by Google App Engine
This is Rietveld 408576698