third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

index 49c62adc6f2204eaf5a05111a01d4c3264bd10af..70494e5acedb5330ce3145addb85873f57e7e752 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js

@@ -39,7 +39,7 @@ Console.ConsoleContextSelector = class {

if (!executionContext.isDefault)

depth++;

if (executionContext.frameId) {

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);

+ var resourceTreeModel = target.model(SDK.ResourceTreeModel);

var frame = resourceTreeModel && resourceTreeModel.frameForId(executionContext.frameId);

if (frame) {

label = label || frame.displayName();

@@ -170,7 +170,7 @@ Console.ConsoleContextSelector = class {

_isTopContext(executionContext) {

if (!executionContext || !executionContext.isDefault)

return false;

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(executionContext.target());

+ var resourceTreeModel = executionContext.target().model(SDK.ResourceTreeModel);

var frame = executionContext.frameId && resourceTreeModel && resourceTreeModel.frameForId(executionContext.frameId);

if (!frame)

return false;