third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-names.html - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-names.html

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="cache-storage-test.js"></script>	4 <script src="cache-storage-test.js"></script>

5 <script>	5 <script>

6 function test()	6 function test()

7 {	7 {

8 var cacheStorageModel = SDK.ServiceWorkerCacheModel.fromTarget(SDK.targetMan ager.mainTarget());	8 var cacheStorageModel = InspectorTest.mainTarget.model(SDK.ServiceWorkerCach eModel);

9 cacheStorageModel.enable();	9 cacheStorageModel.enable();

10	10

11 function errorAndExit(error)	11 function errorAndExit(error)

12 {	12 {

13 if (error)	13 if (error)

14 InspectorTest.addResult(error);	14 InspectorTest.addResult(error);

15 InspectorTest.completeTest();	15 InspectorTest.completeTest();

16 }	16 }

17	17

18 function main()	18 function main()

(...skipping 12 matching lines...) Expand all Loading...
31 }	31 }

32	32

33 InspectorTest.waitForCacheRefresh(main);	33 InspectorTest.waitForCacheRefresh(main);

34 }	34 }

35 </script>	35 </script>

36 </head>	36 </head>

37 <body onload="runTest()">	37 <body onload="runTest()">

38 <p>Tests that cache names are correctly loaded and displayed in the inspector.</ p>	38 <p>Tests that cache names are correctly loaded and displayed in the inspector.</ p>

39 </body>	39 </body>

40 </html>	40 </html>

OLD	NEW