Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed)

Created:
10 years ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, stuartmorgan+watch_chromium.org, dhollowa, ncarter (slow), fbarchard, idana, Erik does not do reviews, ben+cc_chromium.org, jam, dmac, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, James Hawkins, scherkus (not reviewing), michaeln, sjl, Sergey Ulanov, Alpha Left Google, Aaron Boodman, acolwell GONE FROM CHROMIUM, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add the "virtual" keyword on method overrides that are missing it. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68606

Patch Set 1 #

Patch Set 2 : Missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -535 lines) Patch
M app/hi_res_timer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M app/slide_animation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_descriptor_shuffle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/message_loop_proxy_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/values.h View 5 chunks +10 lines, -10 lines 0 comments Download
M base/waitable_event_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/credit_card.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/home_address.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/foreign_session_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/collected_cookies_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/passwords_page_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/overflow_button.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/slide_animator_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/status_bubble_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_default.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/device_management_policy_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/file_based_policy_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_import_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/renderer_host/site_instance.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/x509_user_cert_resource_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/speech/speech_recognition_request.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/speech/speech_recognizer.h View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/database_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 8 chunks +36 lines, -41 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/utility_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/worker_host/worker_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/json_value_serializer.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/security_filter_peer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/plugin/npobject_proxy.h View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/plugin/npobject_proxy.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/plugin/npobject_stub.h View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/plugin/npobject_stub.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_channel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 4 chunks +31 lines, -32 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/geolocation_dispatcher_old.h View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/renderer/media/audio_renderer_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/renderer/plugin_channel_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_histogram_snapshots.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/renderer_webidbobjectstore_impl.h View 1 chunk +24 lines, -24 lines 0 comments Download
M chrome/renderer/speech_input_dispatcher.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/websharedworker_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webworker_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/worker/nativewebworker_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/directory_lister.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/listen_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_digest.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_net_log_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/server/http_listen_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/https_prober.h View 1 chunk +7 lines, -7 lines 0 comments Download
M net/url_request/url_request_redirect_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_redirect_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_net_log_params.h View 1 chunk +3 lines, -38 lines 0 comments Download
A net/websockets/websocket_net_log_params.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/jingle_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/jingle_glue/xmpp_socket_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_update_job.h View 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/glue/plugins/pepper_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_directory_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_directory_reader.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_file_chooser.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_file_chooser.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_file_io.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_file_io.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_file_ref.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_file_ref.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_file_system.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_font.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_font.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_scrollbar.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_url_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_url_loader.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_url_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_url_request_info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_url_response_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_url_response_info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_video_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_widget.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.h View 1 chunk +11 lines, -15 lines 0 comments Download
M webkit/glue/plugins/plugin_stream_url.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_impl.h View 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Just seeking rubber stamp.
10 years ago (2010-12-08 17:44:26 UTC) #1
Lei Zhang
10 years ago (2010-12-08 17:54:01 UTC) #2 
*stamp*

Powered by Google App Engine
This is Rietveld 408576698