chrome/browser/parsers/metadata_parser_filebase.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/parsers/metadata_parser_filebase.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/parsers/metadata_parser_filebase.h

diff --git a/chrome/browser/parsers/metadata_parser_filebase.h b/chrome/browser/parsers/metadata_parser_filebase.h

index 9ed5775094f7cbcd2fddb24fb64a0dabb73d25fd..e1614a895d6e8dad96186b2cabbedaa0b618ba3c 100644

--- a/chrome/browser/parsers/metadata_parser_filebase.h

+++ b/chrome/browser/parsers/metadata_parser_filebase.h

@@ -27,7 +27,7 @@ class FileMetadataParser : public MetadataParser {

virtual bool Parse();

virtual bool GetProperty(const std::string& key, std::string* value);

- MetadataPropertyIterator* GetPropertyIterator();

+ virtual MetadataPropertyIterator* GetPropertyIterator();

protected:

PropertyMap properties_;