Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: webkit/glue/plugins/webplugin_impl.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/plugin_stream_url.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 5 #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
6 #define WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 6 #define WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 virtual WebKit::WebString selectionAsText() const; 97 virtual WebKit::WebString selectionAsText() const;
98 virtual WebKit::WebString selectionAsMarkup() const; 98 virtual WebKit::WebString selectionAsMarkup() const;
99 virtual void setZoomFactor(float scale, bool text_only); 99 virtual void setZoomFactor(float scale, bool text_only);
100 virtual bool startFind(const WebKit::WebString& search_text, 100 virtual bool startFind(const WebKit::WebString& search_text,
101 bool case_sensitive, 101 bool case_sensitive,
102 int identifier); 102 int identifier);
103 virtual void selectFindResult(bool forward); 103 virtual void selectFindResult(bool forward);
104 virtual void stopFind(); 104 virtual void stopFind();
105 105
106 // WebPlugin implementation: 106 // WebPlugin implementation:
107 void SetWindow(gfx::PluginWindowHandle window); 107 virtual void SetWindow(gfx::PluginWindowHandle window);
108 virtual void SetAcceptsInputEvents(bool accepts) { 108 virtual void SetAcceptsInputEvents(bool accepts) {
109 accepts_input_events_ = accepts; 109 accepts_input_events_ = accepts;
110 } 110 }
111 void WillDestroyWindow(gfx::PluginWindowHandle window); 111 virtual void WillDestroyWindow(gfx::PluginWindowHandle window);
112 #if defined(OS_WIN) 112 #if defined(OS_WIN)
113 void SetWindowlessPumpEvent(HANDLE pump_messages_event) { } 113 void SetWindowlessPumpEvent(HANDLE pump_messages_event) { }
114 #endif 114 #endif
115 virtual void CancelResource(unsigned long id); 115 virtual void CancelResource(unsigned long id);
116 virtual void Invalidate(); 116 virtual void Invalidate();
117 virtual void InvalidateRect(const gfx::Rect& rect); 117 virtual void InvalidateRect(const gfx::Rect& rect);
118 virtual NPObject* GetWindowScriptNPObject(); 118 virtual NPObject* GetWindowScriptNPObject();
119 virtual NPObject* GetPluginElement(); 119 virtual NPObject* GetPluginElement();
120 virtual void SetCookie(const GURL& url, 120 virtual void SetCookie(const GURL& url,
121 const GURL& first_party_for_cookies, 121 const GURL& first_party_for_cookies,
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 const WebKit::WebURLError& error); 213 const WebKit::WebURLError& error);
214 214
215 // Helper function to remove the stored information about a resource 215 // Helper function to remove the stored information about a resource
216 // request given its index in m_clients. 216 // request given its index in m_clients.
217 void RemoveClient(size_t i); 217 void RemoveClient(size_t i);
218 218
219 // Helper function to remove the stored information about a resource 219 // Helper function to remove the stored information about a resource
220 // request given a handle. 220 // request given a handle.
221 void RemoveClient(WebKit::WebURLLoader* loader); 221 void RemoveClient(WebKit::WebURLLoader* loader);
222 222
223 void HandleURLRequest(const char* url, 223 virtual void HandleURLRequest(const char* url,
224 const char *method, 224 const char *method,
225 const char* target, 225 const char* target,
226 const char* buf, 226 const char* buf,
227 unsigned int len, 227 unsigned int len,
228 int notify_id, 228 int notify_id,
229 bool popups_allowed, 229 bool popups_allowed,
230 bool notify_redirects); 230 bool notify_redirects);
231 231
232 void CancelDocumentLoad(); 232 virtual void CancelDocumentLoad();
233 233
234 void InitiateHTTPRangeRequest( 234 virtual void InitiateHTTPRangeRequest(
235 const char* url, const char* range_info, int pending_request_id); 235 const char* url, const char* range_info, int pending_request_id);
236 236
237 void SetDeferResourceLoading(unsigned long resource_id, bool defer); 237 virtual void SetDeferResourceLoading(unsigned long resource_id, bool defer);
238 238
239 // Ignore in-process plugins mode for this flag. 239 // Ignore in-process plugins mode for this flag.
240 bool IsOffTheRecord() { return false; } 240 virtual bool IsOffTheRecord() { return false; }
241 241
242 // Handles HTTP multipart responses, i.e. responses received with a HTTP 242 // Handles HTTP multipart responses, i.e. responses received with a HTTP
243 // status code of 206. 243 // status code of 206.
244 void HandleHttpMultipartResponse(const WebKit::WebURLResponse& response, 244 void HandleHttpMultipartResponse(const WebKit::WebURLResponse& response,
245 WebPluginResourceClient* client); 245 WebPluginResourceClient* client);
246 246
247 void HandleURLRequestInternal(const char* url, 247 void HandleURLRequestInternal(const char* url,
248 const char* method, 248 const char* method,
249 const char* target, 249 const char* target,
250 const char* buf, 250 const char* buf,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 std::vector<std::string> arg_values_; 323 std::vector<std::string> arg_values_;
324 324
325 ScopedRunnableMethodFactory<WebPluginImpl> method_factory_; 325 ScopedRunnableMethodFactory<WebPluginImpl> method_factory_;
326 326
327 DISALLOW_COPY_AND_ASSIGN(WebPluginImpl); 327 DISALLOW_COPY_AND_ASSIGN(WebPluginImpl);
328 }; 328 };
329 329
330 } // namespace webkit_glue 330 } // namespace webkit_glue
331 331
332 #endif // #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 332 #endif // #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/plugin_stream_url.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698