Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3248)

Unified Diff: chrome/browser/renderer_host/sync_resource_handler.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/sync_resource_handler.h
diff --git a/chrome/browser/renderer_host/sync_resource_handler.h b/chrome/browser/renderer_host/sync_resource_handler.h
index 6f86de72ac35d2584932eee15499a32e740f99f3..81c4a9a76903a31a160cd9e3bd53710dc8836e5b 100644
--- a/chrome/browser/renderer_host/sync_resource_handler.h
+++ b/chrome/browser/renderer_host/sync_resource_handler.h
@@ -26,18 +26,18 @@ class SyncResourceHandler : public ResourceHandler {
IPC::Message* result_message,
ResourceDispatcherHost* resource_dispatcher_host);
- bool OnUploadProgress(int request_id, uint64 position, uint64 size);
- bool OnRequestRedirected(int request_id, const GURL& new_url,
- ResourceResponse* response, bool* defer);
- bool OnResponseStarted(int request_id, ResourceResponse* response);
- bool OnWillStart(int request_id, const GURL& url, bool* defer);
- bool OnWillRead(int request_id, net::IOBuffer** buf, int* buf_size,
- int min_size);
- bool OnReadCompleted(int request_id, int* bytes_read);
- bool OnResponseCompleted(int request_id,
- const URLRequestStatus& status,
- const std::string& security_info);
- void OnRequestClosed();
+ virtual bool OnUploadProgress(int request_id, uint64 position, uint64 size);
+ virtual bool OnRequestRedirected(int request_id, const GURL& new_url,
+ ResourceResponse* response, bool* defer);
+ virtual bool OnResponseStarted(int request_id, ResourceResponse* response);
+ virtual bool OnWillStart(int request_id, const GURL& url, bool* defer);
+ virtual bool OnWillRead(int request_id, net::IOBuffer** buf, int* buf_size,
+ int min_size);
+ virtual bool OnReadCompleted(int request_id, int* bytes_read);
+ virtual bool OnResponseCompleted(int request_id,
+ const URLRequestStatus& status,
+ const std::string& security_info);
+ virtual void OnRequestClosed();
private:
enum { kReadBufSize = 3840 };
« no previous file with comments | « chrome/browser/renderer_host/site_instance.h ('k') | chrome/browser/renderer_host/x509_user_cert_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698