chrome/browser/importer/importer.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/importer.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/importer/importer.h

diff --git a/chrome/browser/importer/importer.h b/chrome/browser/importer/importer.h

index d8cecac27f1f2ec8bd1574d8266656378854cf12..7c527fac960a323b38bb7a7646432376349804d9 100644

--- a/chrome/browser/importer/importer.h

+++ b/chrome/browser/importer/importer.h

@@ -109,9 +109,9 @@ class ImporterHost : public base::RefCountedThreadSafe<ImporterHost>,

// NotificationObserver implementation. Called when TemplateURLModel has been

// loaded.

- void Observe(NotificationType type,

- const NotificationSource& source,

- const NotificationDetails& details);

+ virtual void Observe(NotificationType type,

+ const NotificationSource& source,

+ const NotificationDetails& details);

// ShowWarningDialog() asks user to close the application that is owning the

// lock. They can retry or skip the importing process.