Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: webkit/glue/plugins/pepper_scrollbar.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/pepper_font.cc ('k') | webkit/glue/plugins/pepper_scrollbar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_ 5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_
6 #define WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_ 6 #define WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "gfx/rect.h" 10 #include "gfx/rect.h"
11 #include "ppapi/c/dev/ppb_scrollbar_dev.h" 11 #include "ppapi/c/dev/ppb_scrollbar_dev.h"
12 #include "third_party/WebKit/WebKit/chromium/public/WebRect.h" 12 #include "third_party/WebKit/WebKit/chromium/public/WebRect.h"
13 #include "third_party/WebKit/WebKit/chromium/public/WebScrollbarClient.h" 13 #include "third_party/WebKit/WebKit/chromium/public/WebScrollbarClient.h"
14 #include "webkit/glue/plugins/pepper_widget.h" 14 #include "webkit/glue/plugins/pepper_widget.h"
15 15
16 namespace pepper { 16 namespace pepper {
17 17
18 class PluginInstance; 18 class PluginInstance;
19 19
20 class Scrollbar : public Widget, public WebKit::WebScrollbarClient { 20 class Scrollbar : public Widget, public WebKit::WebScrollbarClient {
21 public: 21 public:
22 Scrollbar(PluginInstance* instance, bool vertical); 22 Scrollbar(PluginInstance* instance, bool vertical);
23 virtual ~Scrollbar(); 23 virtual ~Scrollbar();
24 24
25 // Returns a pointer to the interface implementing PPB_Scrollbar that is 25 // Returns a pointer to the interface implementing PPB_Scrollbar that is
26 // exposed to the plugin. 26 // exposed to the plugin.
27 static const PPB_Scrollbar_Dev* GetInterface(); 27 static const PPB_Scrollbar_Dev* GetInterface();
28 28
29 // Resource overrides. 29 // Resource overrides.
30 Scrollbar* AsScrollbar() { return this; } 30 virtual Scrollbar* AsScrollbar();
31 31
32 // PPB_Scrollbar implementation. 32 // PPB_Scrollbar implementation.
33 uint32_t GetValue(); 33 uint32_t GetValue();
34 void SetValue(uint32_t value); 34 void SetValue(uint32_t value);
35 void SetDocumentSize(uint32_t size); 35 void SetDocumentSize(uint32_t size);
36 void SetTickMarks(const PP_Rect* tick_marks, uint32_t count); 36 void SetTickMarks(const PP_Rect* tick_marks, uint32_t count);
37 void ScrollBy(PP_ScrollBy_Dev unit, int32_t multiplier); 37 void ScrollBy(PP_ScrollBy_Dev unit, int32_t multiplier);
38 38
39 // PPB_Widget implementation. 39 // PPB_Widget implementation.
40 virtual bool Paint(const PP_Rect* rect, ImageData* image); 40 virtual bool Paint(const PP_Rect* rect, ImageData* image);
(...skipping 12 matching lines...) Expand all
53 void NotifyInvalidate(); 53 void NotifyInvalidate();
54 54
55 gfx::Rect dirty_; 55 gfx::Rect dirty_;
56 std::vector<WebKit::WebRect> tickmarks_; 56 std::vector<WebKit::WebRect> tickmarks_;
57 scoped_ptr<WebKit::WebScrollbar> scrollbar_; 57 scoped_ptr<WebKit::WebScrollbar> scrollbar_;
58 }; 58 };
59 59
60 } // namespace pepper 60 } // namespace pepper
61 61
62 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_ 62 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_SCROLLBAR_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/pepper_font.cc ('k') | webkit/glue/plugins/pepper_scrollbar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698