Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/service/gaia/service_gaia_authenticator.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/webworker_proxy.h ('k') | chrome/service/service_utility_process_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_ 5 #ifndef CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_
6 #define CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_ 6 #define CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 13 matching lines...) Expand all
24 public URLFetcher::Delegate, 24 public URLFetcher::Delegate,
25 public gaia::GaiaAuthenticator { 25 public gaia::GaiaAuthenticator {
26 public: 26 public:
27 ServiceGaiaAuthenticator(const std::string& user_agent, 27 ServiceGaiaAuthenticator(const std::string& user_agent,
28 const std::string& service_id, 28 const std::string& service_id,
29 const std::string& gaia_url, 29 const std::string& gaia_url,
30 base::MessageLoopProxy* io_message_loop_proxy); 30 base::MessageLoopProxy* io_message_loop_proxy);
31 ~ServiceGaiaAuthenticator(); 31 ~ServiceGaiaAuthenticator();
32 32
33 // URLFetcher::Delegate implementation. 33 // URLFetcher::Delegate implementation.
34 void OnURLFetchComplete(const URLFetcher *source, const GURL &url, 34 virtual void OnURLFetchComplete(const URLFetcher *source,
35 const URLRequestStatus &status, int response_code, 35 const GURL &url,
36 const ResponseCookies &cookies, 36 const URLRequestStatus &status,
37 const std::string &data); 37 int response_code,
38 const ResponseCookies &cookies,
39 const std::string &data);
38 40
39 protected: 41 protected:
40 // GaiaAuthenticator overrides. 42 // GaiaAuthenticator overrides.
41 virtual bool Post(const GURL& url, const std::string& post_body, 43 virtual bool Post(const GURL& url, const std::string& post_body,
42 unsigned long* response_code, std::string* response_body); 44 unsigned long* response_code, std::string* response_body);
43 virtual int GetBackoffDelaySeconds(int current_backoff_delay); 45 virtual int GetBackoffDelaySeconds(int current_backoff_delay);
44 46
45 private: 47 private:
46 void DoPost(const GURL& post_url, const std::string& post_body); 48 void DoPost(const GURL& post_url, const std::string& post_body);
47 49
48 base::WaitableEvent http_post_completed_; 50 base::WaitableEvent http_post_completed_;
49 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_; 51 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
50 int http_response_code_; 52 int http_response_code_;
51 std::string response_data_; 53 std::string response_data_;
52 54
53 DISALLOW_COPY_AND_ASSIGN(ServiceGaiaAuthenticator); 55 DISALLOW_COPY_AND_ASSIGN(ServiceGaiaAuthenticator);
54 }; 56 };
55 57
56 #endif // CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_ 58 #endif // CHROME_SERVICE_GAIA_SERVICE_GAIA_AUTHENTICATOR_H_
57 59
OLDNEW
« no previous file with comments | « chrome/renderer/webworker_proxy.h ('k') | chrome/service/service_utility_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698