Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/task_manager/task_manager.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager.h
diff --git a/chrome/browser/task_manager/task_manager.h b/chrome/browser/task_manager/task_manager.h
index 5b33c7596abc85607db067eab0e4f34435388b73..bd8ac5f005278eaa87c126a46a88e5945644490e 100644
--- a/chrome/browser/task_manager/task_manager.h
+++ b/chrome/browser/task_manager/task_manager.h
@@ -297,13 +297,16 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver,
const Extension* GetResourceExtension(int index) const;
// JobObserver methods:
- void OnJobAdded(net::URLRequestJob* job);
- void OnJobRemoved(net::URLRequestJob* job);
- void OnJobDone(net::URLRequestJob* job, const URLRequestStatus& status);
- void OnJobRedirect(net::URLRequestJob* job,
- const GURL& location,
- int status_code);
- void OnBytesRead(net::URLRequestJob* job, const char* buf, int byte_count);
+ virtual void OnJobAdded(net::URLRequestJob* job);
+ virtual void OnJobRemoved(net::URLRequestJob* job);
+ virtual void OnJobDone(net::URLRequestJob* job,
+ const URLRequestStatus& status);
+ virtual void OnJobRedirect(net::URLRequestJob* job,
+ const GURL& location,
+ int status_code);
+ virtual void OnBytesRead(net::URLRequestJob* job,
+ const char* buf,
+ int byte_count);
void AddResourceProvider(TaskManager::ResourceProvider* provider);
void RemoveResourceProvider(TaskManager::ResourceProvider* provider);
« no previous file with comments | « chrome/browser/sync/glue/password_model_worker.h ('k') | chrome/browser/task_manager/task_manager_resource_providers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698