Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: webkit/glue/plugins/pepper_buffer.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/appcache/appcache_update_job.h ('k') | webkit/glue/plugins/pepper_buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_ 5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_
6 #define WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_ 6 #define WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/scoped_ptr.h" 9 #include "base/scoped_ptr.h"
10 #include "webkit/glue/plugins/pepper_resource.h" 10 #include "webkit/glue/plugins/pepper_resource.h"
(...skipping 14 matching lines...) Expand all
25 25
26 // Returns true if this buffer is mapped. False means that the buffer is 26 // Returns true if this buffer is mapped. False means that the buffer is
27 // either invalid or not mapped. 27 // either invalid or not mapped.
28 bool is_mapped() const { return !!mem_buffer_.get(); } 28 bool is_mapped() const { return !!mem_buffer_.get(); }
29 29
30 // Returns a pointer to the interface implementing PPB_Buffer that is 30 // Returns a pointer to the interface implementing PPB_Buffer that is
31 // exposed to the plugin. 31 // exposed to the plugin.
32 static const PPB_Buffer_Dev* GetInterface(); 32 static const PPB_Buffer_Dev* GetInterface();
33 33
34 // Resource overrides. 34 // Resource overrides.
35 Buffer* AsBuffer() { return this; } 35 virtual Buffer* AsBuffer();
36 36
37 // PPB_Buffer implementation. 37 // PPB_Buffer implementation.
38 bool Init(uint32_t size); 38 bool Init(uint32_t size);
39 void Describe(uint32_t* size_in_bytes) const; 39 void Describe(uint32_t* size_in_bytes) const;
40 void* Map(); 40 void* Map();
41 void Unmap(); 41 void Unmap();
42 42
43 // Swaps the guts of this buffer with another. 43 // Swaps the guts of this buffer with another.
44 void Swap(Buffer* other); 44 void Swap(Buffer* other);
45 45
46 private: 46 private:
47 uint32_t size_; 47 uint32_t size_;
48 scoped_array<unsigned char> mem_buffer_; 48 scoped_array<unsigned char> mem_buffer_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(Buffer); 50 DISALLOW_COPY_AND_ASSIGN(Buffer);
51 }; 51 };
52 52
53 } // namespace pepper 53 } // namespace pepper
54 54
55 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_ 55 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_BUFFER_H_
56 56
OLDNEW
« no previous file with comments | « webkit/appcache/appcache_update_job.h ('k') | webkit/glue/plugins/pepper_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698