Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: chrome/renderer/renderer_histogram_snapshots.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_ 5 #ifndef CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_
6 #define CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_ 6 #define CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 19 matching lines...) Expand all
30 typedef std::vector<std::string> HistogramPickledList; 30 typedef std::vector<std::string> HistogramPickledList;
31 31
32 // Extract snapshot data and then send it off the the Browser process. 32 // Extract snapshot data and then send it off the the Browser process.
33 // Send only a delta to what we have already sent. 33 // Send only a delta to what we have already sent.
34 void UploadAllHistrograms(int sequence_number); 34 void UploadAllHistrograms(int sequence_number);
35 35
36 ScopedRunnableMethodFactory<RendererHistogramSnapshots> 36 ScopedRunnableMethodFactory<RendererHistogramSnapshots>
37 renderer_histogram_snapshots_factory_; 37 renderer_histogram_snapshots_factory_;
38 38
39 // HistogramSender interface (override) methods. 39 // HistogramSender interface (override) methods.
40 void TransmitHistogramDelta( 40 virtual void TransmitHistogramDelta(
41 const base::Histogram& histogram, 41 const base::Histogram& histogram,
42 const base::Histogram::SampleSet& snapshot); 42 const base::Histogram::SampleSet& snapshot);
43 void InconsistencyDetected(int problem); 43 virtual void InconsistencyDetected(int problem);
44 void UniqueInconsistencyDetected(int problem); 44 virtual void UniqueInconsistencyDetected(int problem);
45 void SnapshotProblemResolved(int amount); 45 virtual void SnapshotProblemResolved(int amount);
46 46
47 // Collection of histograms to send to the browser. 47 // Collection of histograms to send to the browser.
48 HistogramPickledList pickled_histograms_; 48 HistogramPickledList pickled_histograms_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(RendererHistogramSnapshots); 50 DISALLOW_COPY_AND_ASSIGN(RendererHistogramSnapshots);
51 }; 51 };
52 52
53 #endif // CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_ 53 #endif // CHROME_RENDERER_RENDERER_HISTOGRAM_SNAPSHOTS_H_
OLDNEW
« no previous file with comments | « chrome/renderer/plugin_channel_host.h ('k') | chrome/renderer/renderer_webidbobjectstore_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698