Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/gtk/browser_toolbar_gtk.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_ 5 #ifndef CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_
6 #define CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_ 6 #define CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 #include <string> 10 #include <string>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // Overridden from MenuGtk::Delegate: 91 // Overridden from MenuGtk::Delegate:
92 virtual void StoppedShowing(); 92 virtual void StoppedShowing();
93 virtual GtkIconSet* GetIconSetForId(int idr); 93 virtual GtkIconSet* GetIconSetForId(int idr);
94 virtual bool AlwaysShowIconForCmd(int command_id) const; 94 virtual bool AlwaysShowIconForCmd(int command_id) const;
95 95
96 // Overridden from menus::AcceleratorProvider: 96 // Overridden from menus::AcceleratorProvider:
97 virtual bool GetAcceleratorForCommandId(int id, 97 virtual bool GetAcceleratorForCommandId(int id,
98 menus::Accelerator* accelerator); 98 menus::Accelerator* accelerator);
99 99
100 // NotificationObserver implementation. 100 // NotificationObserver implementation.
101 void Observe(NotificationType type, 101 virtual void Observe(NotificationType type,
102 const NotificationSource& source, 102 const NotificationSource& source,
103 const NotificationDetails& details); 103 const NotificationDetails& details);
104 104
105 Profile* profile() { return profile_; } 105 Profile* profile() { return profile_; }
106 void SetProfile(Profile* profile); 106 void SetProfile(Profile* profile);
107 107
108 // Message that we should react to a state change. 108 // Message that we should react to a state change.
109 void UpdateTabContents(TabContents* contents, bool should_restore_state); 109 void UpdateTabContents(TabContents* contents, bool should_restore_state);
110 110
111 private: 111 private:
112 // Connect/Disconnect signals for dragging a url onto the home button. 112 // Connect/Disconnect signals for dragging a url onto the home button.
113 void SetUpDragForHomeButton(bool enable); 113 void SetUpDragForHomeButton(bool enable);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 // rendering. 210 // rendering.
211 OwnedWidgetGtk offscreen_entry_; 211 OwnedWidgetGtk offscreen_entry_;
212 212
213 // Manages the home button drop signal handler. 213 // Manages the home button drop signal handler.
214 scoped_ptr<GtkSignalRegistrar> drop_handler_; 214 scoped_ptr<GtkSignalRegistrar> drop_handler_;
215 215
216 DISALLOW_COPY_AND_ASSIGN(BrowserToolbarGtk); 216 DISALLOW_COPY_AND_ASSIGN(BrowserToolbarGtk);
217 }; 217 };
218 218
219 #endif // CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_ 219 #endif // CHROME_BROWSER_GTK_BROWSER_TOOLBAR_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/gtk/browser_actions_toolbar_gtk.h ('k') | chrome/browser/gtk/collected_cookies_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698