Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: webkit/glue/plugins/pepper_url_loader.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/pepper_scrollbar.cc ('k') | webkit/glue/plugins/pepper_url_loader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_ 5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_
6 #define WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_ 6 #define WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
(...skipping 26 matching lines...) Expand all
37 37
38 // Returns a pointer to the interface implementing PPB_URLLoader that is 38 // Returns a pointer to the interface implementing PPB_URLLoader that is
39 // exposed to the plugin. 39 // exposed to the plugin.
40 static const PPB_URLLoader* GetInterface(); 40 static const PPB_URLLoader* GetInterface();
41 41
42 // Returns a pointer to the interface implementing PPB_URLLoaderTrusted that 42 // Returns a pointer to the interface implementing PPB_URLLoaderTrusted that
43 // is exposed to the plugin. 43 // is exposed to the plugin.
44 static const PPB_URLLoaderTrusted* GetTrustedInterface(); 44 static const PPB_URLLoaderTrusted* GetTrustedInterface();
45 45
46 // Resource overrides. 46 // Resource overrides.
47 URLLoader* AsURLLoader() { return this; } 47 virtual URLLoader* AsURLLoader();
48 48
49 // PPB_URLLoader implementation. 49 // PPB_URLLoader implementation.
50 int32_t Open(URLRequestInfo* request, PP_CompletionCallback callback); 50 int32_t Open(URLRequestInfo* request, PP_CompletionCallback callback);
51 int32_t FollowRedirect(PP_CompletionCallback callback); 51 int32_t FollowRedirect(PP_CompletionCallback callback);
52 bool GetUploadProgress(int64_t* bytes_sent, 52 bool GetUploadProgress(int64_t* bytes_sent,
53 int64_t* total_bytes_to_be_sent); 53 int64_t* total_bytes_to_be_sent);
54 bool GetDownloadProgress(int64_t* bytes_received, 54 bool GetDownloadProgress(int64_t* bytes_received,
55 int64_t* total_bytes_to_be_received); 55 int64_t* total_bytes_to_be_received);
56 int32_t ReadResponseBody(char* buffer, int32_t bytes_to_read, 56 int32_t ReadResponseBody(char* buffer, int32_t bytes_to_read,
57 PP_CompletionCallback callback); 57 PP_CompletionCallback callback);
(...skipping 17 matching lines...) Expand all
75 int data_length); 75 int data_length);
76 virtual void didReceiveData(WebKit::WebURLLoader* loader, 76 virtual void didReceiveData(WebKit::WebURLLoader* loader,
77 const char* data, 77 const char* data,
78 int data_length); 78 int data_length);
79 virtual void didFinishLoading(WebKit::WebURLLoader* loader, 79 virtual void didFinishLoading(WebKit::WebURLLoader* loader,
80 double finish_time); 80 double finish_time);
81 virtual void didFail(WebKit::WebURLLoader* loader, 81 virtual void didFail(WebKit::WebURLLoader* loader,
82 const WebKit::WebURLError& error); 82 const WebKit::WebURLError& error);
83 83
84 // PluginInstance::Observer implementation. 84 // PluginInstance::Observer implementation.
85 void InstanceDestroyed(PluginInstance* instance); 85 virtual void InstanceDestroyed(PluginInstance* instance);
86 86
87 URLResponseInfo* response_info() const { return response_info_; } 87 URLResponseInfo* response_info() const { return response_info_; }
88 88
89 private: 89 private:
90 void RunCallback(int32_t result); 90 void RunCallback(int32_t result);
91 size_t FillUserBuffer(); 91 size_t FillUserBuffer();
92 92
93 // Converts a WebURLResponse to a URLResponseInfo and saves it. 93 // Converts a WebURLResponse to a URLResponseInfo and saves it.
94 void SaveResponse(const WebKit::WebURLResponse& response); 94 void SaveResponse(const WebKit::WebURLResponse& response);
95 95
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 int32_t done_status_; 131 int32_t done_status_;
132 132
133 bool has_universal_access_; 133 bool has_universal_access_;
134 134
135 PP_URLLoaderTrusted_StatusCallback status_callback_; 135 PP_URLLoaderTrusted_StatusCallback status_callback_;
136 }; 136 };
137 137
138 } // namespace pepper 138 } // namespace pepper
139 139
140 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_ 140 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_URL_LOADER_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/pepper_scrollbar.cc ('k') | webkit/glue/plugins/pepper_url_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698