Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3463)

Unified Diff: chrome/browser/password_manager/password_store_default.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/parsers/metadata_parser_filebase.h ('k') | chrome/browser/plugin_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store_default.h
diff --git a/chrome/browser/password_manager/password_store_default.h b/chrome/browser/password_manager/password_store_default.h
index 38c7440e62c73878524f38f28d88936b4cd435cd..6652958bca211bfaf0948f77b5a93e00b7aa4fd5 100644
--- a/chrome/browser/password_manager/password_store_default.h
+++ b/chrome/browser/password_manager/password_store_default.h
@@ -27,26 +27,26 @@ class PasswordStoreDefault : public PasswordStore,
virtual ~PasswordStoreDefault();
// Implements PasswordStore interface.
- void ReportMetricsImpl();
- void AddLoginImpl(const webkit_glue::PasswordForm& form);
- void UpdateLoginImpl(const webkit_glue::PasswordForm& form);
- void RemoveLoginImpl(const webkit_glue::PasswordForm& form);
- void RemoveLoginsCreatedBetweenImpl(const base::Time& delete_begin,
- const base::Time& delete_end);
- void GetLoginsImpl(GetLoginsRequest* request,
- const webkit_glue::PasswordForm& form);
- void GetAutofillableLoginsImpl(GetLoginsRequest* request);
- void GetBlacklistLoginsImpl(GetLoginsRequest* request);
- bool FillAutofillableLogins(
+ virtual void ReportMetricsImpl();
+ virtual void AddLoginImpl(const webkit_glue::PasswordForm& form);
+ virtual void UpdateLoginImpl(const webkit_glue::PasswordForm& form);
+ virtual void RemoveLoginImpl(const webkit_glue::PasswordForm& form);
+ virtual void RemoveLoginsCreatedBetweenImpl(const base::Time& delete_begin,
+ const base::Time& delete_end);
+ virtual void GetLoginsImpl(GetLoginsRequest* request,
+ const webkit_glue::PasswordForm& form);
+ virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request);
+ virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request);
+ virtual bool FillAutofillableLogins(
std::vector<webkit_glue::PasswordForm*>* forms);
- bool FillBlacklistLogins(
+ virtual bool FillBlacklistLogins(
std::vector<webkit_glue::PasswordForm*>* forms);
scoped_refptr<WebDataService> web_data_service_;
// Implements the WebDataService consumer interface.
- void OnWebDataServiceRequestDone(WebDataService::Handle handle,
- const WDTypedResult *result);
+ virtual void OnWebDataServiceRequestDone(WebDataService::Handle handle,
+ const WDTypedResult *result);
protected:
inline bool DeleteAndRecreateDatabaseFile() {
« no previous file with comments | « chrome/browser/parsers/metadata_parser_filebase.h ('k') | chrome/browser/plugin_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698