net/http/http_net_log_params.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_net_log_params.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_net_log_params.h

diff --git a/net/http/http_net_log_params.h b/net/http/http_net_log_params.h

index 6a0b47b73483d9ebb495ceae2866f72b810a9141..1631363f84e57f70fa1b5665ed623116caa5a91c 100644

--- a/net/http/http_net_log_params.h

+++ b/net/http/http_net_log_params.h

@@ -24,7 +24,7 @@ class NetLogHttpRequestParameter : public NetLog::EventParameters {

NetLogHttpRequestParameter(const std::string& line,

const HttpRequestHeaders& headers);

- Value* ToValue() const;

+ virtual Value* ToValue() const;

const HttpRequestHeaders& GetHeaders() const {

return headers_;

@@ -48,7 +48,7 @@ class NetLogHttpResponseParameter : public NetLog::EventParameters {

explicit NetLogHttpResponseParameter(

const scoped_refptr<HttpResponseHeaders>& headers);

- Value* ToValue() const;

+ virtual Value* ToValue() const;

const HttpResponseHeaders& GetHeaders() const {

return *headers_;

« no previous file with comments | « net/http/http_auth_handler_digest.h ('k') | net/http/http_stream_factory.h » ('j') | no next file with comments »