Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: remoting/jingle_glue/xmpp_socket_adapter.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/jingle_glue/jingle_thread.h ('k') | webkit/appcache/appcache_update_job.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_ 5 #ifndef REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_
6 #define REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_ 6 #define REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "third_party/libjingle/source/talk/base/asyncsocket.h" 10 #include "third_party/libjingle/source/talk/base/asyncsocket.h"
(...skipping 21 matching lines...) Expand all
32 virtual int GetError() { return wsa_error_; } 32 virtual int GetError() { return wsa_error_; }
33 33
34 void set_firewall(bool firewall) { firewall_ = firewall; } 34 void set_firewall(bool firewall) { firewall_ = firewall; }
35 35
36 virtual bool Connect(const talk_base::SocketAddress& addr); 36 virtual bool Connect(const talk_base::SocketAddress& addr);
37 virtual bool Read(char* data, size_t len, size_t* len_read); 37 virtual bool Read(char* data, size_t len, size_t* len_read);
38 virtual bool Write(const char* data, size_t len); 38 virtual bool Write(const char* data, size_t len);
39 virtual bool Close(); 39 virtual bool Close();
40 40
41 #if defined(FEATURE_ENABLE_SSL) 41 #if defined(FEATURE_ENABLE_SSL)
42 bool StartTls(const std::string& domainname); 42 virtual bool StartTls(const std::string& domainname);
43 bool IsOpen() const { return state_ == STATE_OPEN 43 bool IsOpen() const { return state_ == STATE_OPEN
44 || state_ == STATE_TLS_OPEN; } 44 || state_ == STATE_TLS_OPEN; }
45 #else 45 #else
46 bool IsOpen() const { return state_ == STATE_OPEN; } 46 bool IsOpen() const { return state_ == STATE_OPEN; }
47 #endif 47 #endif
48 48
49 sigslot::signal0<> SignalAuthenticationError; 49 sigslot::signal0<> SignalAuthenticationError;
50 50
51 private: 51 private:
52 // Return false if the socket is closed. 52 // Return false if the socket is closed.
(...skipping 25 matching lines...) Expand all
78 void FlushWriteQueue(Error* error, int* wsa_error); 78 void FlushWriteQueue(Error* error, int* wsa_error);
79 79
80 void SetError(Error error); 80 void SetError(Error error);
81 void SetWSAError(int error); 81 void SetWSAError(int error);
82 DISALLOW_COPY_AND_ASSIGN(XmppSocketAdapter); 82 DISALLOW_COPY_AND_ASSIGN(XmppSocketAdapter);
83 }; 83 };
84 84
85 } // namespace remoting 85 } // namespace remoting
86 86
87 #endif // REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_ 87 #endif // REMOTING_JINGLE_GLUE_XMPP_SOCKET_ADAPTER_H_
OLDNEW
« no previous file with comments | « remoting/jingle_glue/jingle_thread.h ('k') | webkit/appcache/appcache_update_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698