Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: webkit/glue/plugins/plugin_stream_url.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/pepper_widget.cc ('k') | webkit/glue/plugins/plugin_stream_url.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__ 5 #ifndef WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__
6 #define WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__ 6 #define WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__
7 7
8 8
9 #include "webkit/glue/plugins/plugin_stream.h" 9 #include "webkit/glue/plugins/plugin_stream.h"
10 #include "webkit/glue/plugins/webplugin.h" 10 #include "webkit/glue/plugins/webplugin.h"
(...skipping 25 matching lines...) Expand all
36 36
37 virtual webkit_glue::WebPluginResourceClient* AsResourceClient() { 37 virtual webkit_glue::WebPluginResourceClient* AsResourceClient() {
38 return static_cast<webkit_glue::WebPluginResourceClient*>(this); 38 return static_cast<webkit_glue::WebPluginResourceClient*>(this);
39 } 39 }
40 40
41 virtual void CancelRequest(); 41 virtual void CancelRequest();
42 42
43 // 43 //
44 // WebPluginResourceClient methods 44 // WebPluginResourceClient methods
45 // 45 //
46 void WillSendRequest(const GURL& url, int http_status_code); 46 virtual void WillSendRequest(const GURL& url, int http_status_code);
47 void DidReceiveResponse(const std::string& mime_type, 47 virtual void DidReceiveResponse(const std::string& mime_type,
48 const std::string& headers, 48 const std::string& headers,
49 uint32 expected_length, 49 uint32 expected_length,
50 uint32 last_modified, 50 uint32 last_modified,
51 bool request_is_seekable); 51 bool request_is_seekable);
52 void DidReceiveData(const char* buffer, int length, int data_offset); 52 virtual void DidReceiveData(const char* buffer, int length, int data_offset);
53 void DidFinishLoading(); 53 virtual void DidFinishLoading();
54 void DidFail(); 54 virtual void DidFail();
55 bool IsMultiByteResponseExpected() { 55 virtual bool IsMultiByteResponseExpected();
56 return seekable(); 56 virtual int ResourceId();
57 }
58 int ResourceId() {
59 return id_;
60 }
61 57
62 private: 58 private:
63 GURL url_; 59 GURL url_;
64 unsigned long id_; 60 unsigned long id_;
65 61
66 DISALLOW_COPY_AND_ASSIGN(PluginStreamUrl); 62 DISALLOW_COPY_AND_ASSIGN(PluginStreamUrl);
67 }; 63 };
68 64
69 } // namespace NPAPI 65 } // namespace NPAPI
70 66
71 #endif // WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__ 67 #endif // WEBKIT_GLUE_PLUGIN_PLUGIN_STREAM_URL_H__
OLDNEW
« no previous file with comments | « webkit/glue/plugins/pepper_widget.cc ('k') | webkit/glue/plugins/plugin_stream_url.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698