Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: net/http/http_auth_handler_basic.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/listen_socket.h ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
6 #define NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 6 #define NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 13 matching lines...) Expand all
24 24
25 virtual int CreateAuthHandler(HttpAuth::ChallengeTokenizer* challenge, 25 virtual int CreateAuthHandler(HttpAuth::ChallengeTokenizer* challenge,
26 HttpAuth::Target target, 26 HttpAuth::Target target,
27 const GURL& origin, 27 const GURL& origin,
28 CreateReason reason, 28 CreateReason reason,
29 int digest_nonce_count, 29 int digest_nonce_count,
30 const BoundNetLog& net_log, 30 const BoundNetLog& net_log,
31 scoped_ptr<HttpAuthHandler>* handler); 31 scoped_ptr<HttpAuthHandler>* handler);
32 }; 32 };
33 33
34 HttpAuth::AuthorizationResult HandleAnotherChallenge( 34 virtual HttpAuth::AuthorizationResult HandleAnotherChallenge(
35 HttpAuth::ChallengeTokenizer* challenge); 35 HttpAuth::ChallengeTokenizer* challenge);
36 36
37 protected: 37 protected:
38 virtual bool Init(HttpAuth::ChallengeTokenizer* challenge); 38 virtual bool Init(HttpAuth::ChallengeTokenizer* challenge);
39 39
40 virtual int GenerateAuthTokenImpl(const string16* username, 40 virtual int GenerateAuthTokenImpl(const string16* username,
41 const string16* password, 41 const string16* password,
42 const HttpRequestInfo* request, 42 const HttpRequestInfo* request,
43 CompletionCallback* callback, 43 CompletionCallback* callback,
44 std::string* auth_token); 44 std::string* auth_token);
45 45
46 private: 46 private:
47 ~HttpAuthHandlerBasic() {} 47 ~HttpAuthHandlerBasic() {}
48 48
49 bool ParseChallenge(HttpAuth::ChallengeTokenizer* challenge); 49 bool ParseChallenge(HttpAuth::ChallengeTokenizer* challenge);
50 }; 50 };
51 51
52 } // namespace net 52 } // namespace net
53 53
54 #endif // NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 54 #endif // NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
OLDNEW
« no previous file with comments | « net/base/listen_socket.h ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698