Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: chrome/browser/dom_ui/options/options_ui.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.h ('k') | chrome/browser/download/download_request_limiter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_ 5 #ifndef CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_
6 #define CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_ 6 #define CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 private: 74 private:
75 DISALLOW_COPY_AND_ASSIGN(OptionsPageUIHandler); 75 DISALLOW_COPY_AND_ASSIGN(OptionsPageUIHandler);
76 }; 76 };
77 77
78 class OptionsUI : public DOMUI { 78 class OptionsUI : public DOMUI {
79 public: 79 public:
80 explicit OptionsUI(TabContents* contents); 80 explicit OptionsUI(TabContents* contents);
81 virtual ~OptionsUI(); 81 virtual ~OptionsUI();
82 82
83 static RefCountedMemory* GetFaviconResourceBytes(); 83 static RefCountedMemory* GetFaviconResourceBytes();
84 void RenderViewCreated(RenderViewHost* render_view_host); 84 virtual void RenderViewCreated(RenderViewHost* render_view_host);
85 void DidBecomeActiveForReusedRenderView(); 85 virtual void DidBecomeActiveForReusedRenderView();
86 86
87 void InitializeHandlers(); 87 void InitializeHandlers();
88 88
89 private: 89 private:
90 // Adds OptionsPageUiHandler to the handlers list if handler is enabled. 90 // Adds OptionsPageUiHandler to the handlers list if handler is enabled.
91 void AddOptionsPageUIHandler(DictionaryValue* localized_strings, 91 void AddOptionsPageUIHandler(DictionaryValue* localized_strings,
92 OptionsPageUIHandler* handler); 92 OptionsPageUIHandler* handler);
93 93
94 DISALLOW_COPY_AND_ASSIGN(OptionsUI); 94 DISALLOW_COPY_AND_ASSIGN(OptionsUI);
95 }; 95 };
96 96
97 #endif // CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_ 97 #endif // CHROME_BROWSER_DOM_UI_OPTIONS_OPTIONS_UI_H_
OLDNEW
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.h ('k') | chrome/browser/download/download_request_limiter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698