Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: chrome/browser/renderer_host/x509_user_cert_resource_handler.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/x509_user_cert_resource_handler.h
diff --git a/chrome/browser/renderer_host/x509_user_cert_resource_handler.h b/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
index 54b481d4480bdafb98de814abc8e2266e4157b91..8ae25f83613de61ab76f53f8731b360b2453a4f7 100644
--- a/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
+++ b/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
@@ -30,34 +30,34 @@ class X509UserCertResourceHandler : public ResourceHandler {
net::URLRequest* request,
int render_process_host_id, int render_view_id);
- bool OnUploadProgress(int request_id, uint64 position, uint64 size);
+ virtual bool OnUploadProgress(int request_id, uint64 position, uint64 size);
// Not needed, as this event handler ought to be the final resource.
- bool OnRequestRedirected(int request_id, const GURL& url,
- ResourceResponse* resp, bool* defer);
+ virtual bool OnRequestRedirected(int request_id, const GURL& url,
+ ResourceResponse* resp, bool* defer);
// Check if this indeed an X509 cert.
- bool OnResponseStarted(int request_id, ResourceResponse* resp);
+ virtual bool OnResponseStarted(int request_id, ResourceResponse* resp);
// Pass-through implementation.
- bool OnWillStart(int request_id, const GURL& url, bool* defer);
+ virtual bool OnWillStart(int request_id, const GURL& url, bool* defer);
// Create a new buffer to store received data.
- bool OnWillRead(int request_id, net::IOBuffer** buf, int* buf_size,
- int min_size);
+ virtual bool OnWillRead(int request_id, net::IOBuffer** buf, int* buf_size,
+ int min_size);
// A read was completed, maybe allocate a new buffer for further data.
- bool OnReadCompleted(int request_id, int* bytes_read);
+ virtual bool OnReadCompleted(int request_id, int* bytes_read);
// Done downloading the certificate.
- bool OnResponseCompleted(int request_id,
- const URLRequestStatus& urs,
- const std::string& sec_info);
+ virtual bool OnResponseCompleted(int request_id,
+ const URLRequestStatus& urs,
+ const std::string& sec_info);
- void OnRequestClosed();
+ virtual void OnRequestClosed();
private:
- ~X509UserCertResourceHandler();
+ virtual ~X509UserCertResourceHandler();
void AssembleResource();
« no previous file with comments | « chrome/browser/renderer_host/sync_resource_handler.h ('k') | chrome/browser/repost_form_warning_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698