Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Side by Side Diff: webkit/glue/plugins/pepper_directory_reader.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/plugins/pepper_buffer.cc ('k') | webkit/glue/plugins/pepper_directory_reader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_ 5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_
6 #define WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_ 6 #define WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_
7 7
8 #include <queue> 8 #include <queue>
9 9
10 #include "base/file_util_proxy.h" 10 #include "base/file_util_proxy.h"
(...skipping 10 matching lines...) Expand all
21 class DirectoryReader : public Resource { 21 class DirectoryReader : public Resource {
22 public: 22 public:
23 explicit DirectoryReader(FileRef* directory_ref); 23 explicit DirectoryReader(FileRef* directory_ref);
24 virtual ~DirectoryReader(); 24 virtual ~DirectoryReader();
25 25
26 // Returns a pointer to the interface implementing PPB_DirectoryReader that 26 // Returns a pointer to the interface implementing PPB_DirectoryReader that
27 // is exposed to the plugin. 27 // is exposed to the plugin.
28 static const PPB_DirectoryReader_Dev* GetInterface(); 28 static const PPB_DirectoryReader_Dev* GetInterface();
29 29
30 // Resource overrides. 30 // Resource overrides.
31 DirectoryReader* AsDirectoryReader() { return this; } 31 virtual DirectoryReader* AsDirectoryReader();
32 32
33 // PPB_DirectoryReader implementation. 33 // PPB_DirectoryReader implementation.
34 int32_t GetNextEntry(PP_DirectoryEntry_Dev* entry, 34 int32_t GetNextEntry(PP_DirectoryEntry_Dev* entry,
35 PP_CompletionCallback callback); 35 PP_CompletionCallback callback);
36 36
37 void AddNewEntries(const std::vector<base::FileUtilProxy::Entry>& entries, 37 void AddNewEntries(const std::vector<base::FileUtilProxy::Entry>& entries,
38 bool has_more); 38 bool has_more);
39 39
40 private: 40 private:
41 bool FillUpEntry(); 41 bool FillUpEntry();
42 42
43 scoped_refptr<FileRef> directory_ref_; 43 scoped_refptr<FileRef> directory_ref_;
44 std::queue<base::FileUtilProxy::Entry> entries_; 44 std::queue<base::FileUtilProxy::Entry> entries_;
45 bool has_more_; 45 bool has_more_;
46 PP_DirectoryEntry_Dev* entry_; 46 PP_DirectoryEntry_Dev* entry_;
47 }; 47 };
48 48
49 } // namespace pepper 49 } // namespace pepper
50 50
51 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_ 51 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_DIRECTORY_READER_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/pepper_buffer.cc ('k') | webkit/glue/plugins/pepper_directory_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698