Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3655)

Unified Diff: chrome/plugin/npobject_stub.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/npobject_proxy.cc ('k') | chrome/plugin/npobject_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/npobject_stub.h
diff --git a/chrome/plugin/npobject_stub.h b/chrome/plugin/npobject_stub.h
index fde0a5e5cf21f4b4c6ae43dac0afbdcb708b4917..248d001f280e4cb742f02798b68460f5ee4dd04c 100644
--- a/chrome/plugin/npobject_stub.h
+++ b/chrome/plugin/npobject_stub.h
@@ -39,7 +39,7 @@ class NPObjectStub : public IPC::Channel::Listener,
~NPObjectStub();
// IPC::Message::Sender implementation:
- bool Send(IPC::Message* msg);
+ virtual bool Send(IPC::Message* msg);
// Called when the plugin widget that this NPObject came from is destroyed.
// This is needed because the renderer calls NPN_DeallocateObject on the
@@ -47,18 +47,14 @@ class NPObjectStub : public IPC::Channel::Listener,
void OnPluginDestroyed();
// NPObjectBase implementation.
- virtual NPObject* GetUnderlyingNPObject() {
- return npobject_;
- }
+ virtual NPObject* GetUnderlyingNPObject();
- IPC::Channel::Listener* GetChannelListener() {
- return static_cast<IPC::Channel::Listener*>(this);
- }
+ virtual IPC::Channel::Listener* GetChannelListener();
private:
// IPC::Channel::Listener implementation:
- void OnMessageReceived(const IPC::Message& message);
- void OnChannelError();
+ virtual void OnMessageReceived(const IPC::Message& message);
+ virtual void OnChannelError();
// message handlers
void OnRelease(IPC::Message* reply_msg);
« no previous file with comments | « chrome/plugin/npobject_proxy.cc ('k') | chrome/plugin/npobject_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698