Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: chrome/browser/automation/automation_provider_observers.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/home_address.h ('k') | chrome/browser/bookmarks/bookmark_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider_observers.h
diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h
index f6dfaae5cc3708268632efb13c14490fa9d10d95..2411bb9a9ab969ef49a1505e29af1fbcf7be88d5 100644
--- a/chrome/browser/automation/automation_provider_observers.h
+++ b/chrome/browser/automation/automation_provider_observers.h
@@ -770,7 +770,7 @@ class AutomationProviderSearchEngineObserver
: provider_(provider),
reply_message_(reply_message) {}
- void OnTemplateURLModelChanged();
+ virtual void OnTemplateURLModelChanged();
private:
AutomationProvider* provider_;
@@ -806,10 +806,10 @@ class AutomationProviderImportSettingsObserver
IPC::Message* reply_message)
: provider_(provider),
reply_message_(reply_message) {}
- void ImportStarted() {}
- void ImportItemStarted(importer::ImportItem item) {}
- void ImportItemEnded(importer::ImportItem item) {}
- void ImportEnded();
+ virtual void ImportStarted() {}
+ virtual void ImportItemStarted(importer::ImportItem item) {}
+ virtual void ImportItemEnded(importer::ImportItem item) {}
+ virtual void ImportEnded();
private:
AutomationProvider* provider_;
IPC::Message* reply_message_;
@@ -825,7 +825,7 @@ class AutomationProviderGetPasswordsObserver
: provider_(provider),
reply_message_(reply_message) {}
- void OnPasswordStoreRequestDone(
+ virtual void OnPasswordStoreRequestDone(
int handle, const std::vector<webkit_glue::PasswordForm*>& result);
private:
@@ -842,7 +842,7 @@ class AutomationProviderBrowsingDataObserver
IPC::Message* reply_message)
: provider_(provider),
reply_message_(reply_message) {}
- void OnBrowsingDataRemoverDone();
+ virtual void OnBrowsingDataRemoverDone();
private:
AutomationProvider* provider_;
« no previous file with comments | « chrome/browser/autofill/home_address.h ('k') | chrome/browser/bookmarks/bookmark_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698