base/message_loop_proxy_impl.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop_proxy_impl.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop_proxy_impl.h

diff --git a/base/message_loop_proxy_impl.h b/base/message_loop_proxy_impl.h

index 9aa418dfbaad62d1b621097c03ad9e6333fae7da..44ab2eab574cdcae85f03190f7e016c64ec24e62 100644

--- a/base/message_loop_proxy_impl.h

+++ b/base/message_loop_proxy_impl.h

@@ -33,8 +33,8 @@ class MessageLoopProxyImpl : public MessageLoopProxy,

int64 delay_ms);

virtual bool BelongsToCurrentThread();

-// MessageLoop::DestructionObserver implementation

- void WillDestroyCurrentMessageLoop();

+ // MessageLoop::DestructionObserver implementation

+ virtual void WillDestroyCurrentMessageLoop();

protected:

// Override OnDestruct so that we can delete the object on the target message

« no previous file with comments | « base/file_descriptor_shuffle.h ('k') | base/values.h » ('j') | no next file with comments »