Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: webkit/glue/plugins/pepper_video_decoder.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_ 5 #ifndef WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_
6 #define WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_ 6 #define WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_
7 7
8 #include "base/scoped_ptr.h" 8 #include "base/scoped_ptr.h"
9 #include "webkit/glue/plugins/pepper_plugin_delegate.h" 9 #include "webkit/glue/plugins/pepper_plugin_delegate.h"
10 #include "webkit/glue/plugins/pepper_resource.h" 10 #include "webkit/glue/plugins/pepper_resource.h"
(...skipping 10 matching lines...) Expand all
21 class VideoDecoder : public Resource { 21 class VideoDecoder : public Resource {
22 public: 22 public:
23 VideoDecoder(PluginInstance* instance); 23 VideoDecoder(PluginInstance* instance);
24 virtual ~VideoDecoder(); 24 virtual ~VideoDecoder();
25 25
26 // Returns a pointer to the interface implementing PPB_VideoDecoder that is 26 // Returns a pointer to the interface implementing PPB_VideoDecoder that is
27 // exposed to the plugin. 27 // exposed to the plugin.
28 static const PPB_VideoDecoder_Dev* GetInterface(); 28 static const PPB_VideoDecoder_Dev* GetInterface();
29 29
30 // Resource overrides. 30 // Resource overrides.
31 VideoDecoder* AsVideoDecoder() { return this; } 31 virtual VideoDecoder* AsVideoDecoder();
32 32
33 PluginInstance* instance() { return instance_.get(); } 33 PluginInstance* instance() { return instance_.get(); }
34 34
35 // PPB_VideoDecoder implementation. 35 // PPB_VideoDecoder implementation.
36 bool Init(const PP_VideoDecoderConfig_Dev& decoder_config); 36 bool Init(const PP_VideoDecoderConfig_Dev& decoder_config);
37 bool Decode(PP_VideoCompressedDataBuffer_Dev& input_buffer); 37 bool Decode(PP_VideoCompressedDataBuffer_Dev& input_buffer);
38 int32_t Flush(PP_CompletionCallback& callback); 38 int32_t Flush(PP_CompletionCallback& callback);
39 bool ReturnUncompressedDataBuffer(PP_VideoUncompressedDataBuffer_Dev& buffer); 39 bool ReturnUncompressedDataBuffer(PP_VideoUncompressedDataBuffer_Dev& buffer);
40 40
41 private: 41 private:
42 // This is NULL before initialization, and if this VideoDecoder is 42 // This is NULL before initialization, and if this VideoDecoder is
43 // swapped with another. 43 // swapped with another.
44 scoped_ptr<PluginDelegate::PlatformVideoDecoder> platform_video_decoder_; 44 scoped_ptr<PluginDelegate::PlatformVideoDecoder> platform_video_decoder_;
45 scoped_refptr<PluginInstance> instance_; 45 scoped_refptr<PluginInstance> instance_;
46 }; 46 };
47 47
48 } // namespace pepper 48 } // namespace pepper
49 49
50 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_ 50 #endif // WEBKIT_GLUE_PLUGINS_PEPPER_VIDEO_DECODER_H_
OLDNEW
« no previous file with comments | « webkit/glue/plugins/pepper_url_response_info.cc ('k') | webkit/glue/plugins/pepper_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698