Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/plugin/npobject_proxy.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/security_filter_peer.h ('k') | chrome/plugin/npobject_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/npobject_proxy.h
diff --git a/chrome/plugin/npobject_proxy.h b/chrome/plugin/npobject_proxy.h
index f521b926c1778b48772cf3fea1e52e906cd38f68..6b6e7fff38bf107951be72f63a491e34898f4b2a 100644
--- a/chrome/plugin/npobject_proxy.h
+++ b/chrome/plugin/npobject_proxy.h
@@ -39,7 +39,7 @@ class NPObjectProxy : public IPC::Channel::Listener,
const GURL& page_url);
// IPC::Message::Sender implementation:
- bool Send(IPC::Message* msg);
+ virtual bool Send(IPC::Message* msg);
int route_id() { return route_id_; }
PluginChannelBase* channel() { return channel_; }
@@ -91,13 +91,9 @@ class NPObjectProxy : public IPC::Channel::Listener,
static const NPClass* npclass() { return &npclass_proxy_; }
// NPObjectBase implementation.
- virtual NPObject* GetUnderlyingNPObject() {
- return NULL;
- }
+ virtual NPObject* GetUnderlyingNPObject();
- IPC::Channel::Listener* GetChannelListener() {
- return static_cast<IPC::Channel::Listener*>(this);
- }
+ virtual IPC::Channel::Listener* GetChannelListener();
private:
NPObjectProxy(PluginChannelBase* channel,
@@ -106,8 +102,8 @@ class NPObjectProxy : public IPC::Channel::Listener,
const GURL& page_url);
// IPC::Channel::Listener implementation:
- void OnMessageReceived(const IPC::Message& msg);
- void OnChannelError();
+ virtual void OnMessageReceived(const IPC::Message& msg);
+ virtual void OnChannelError();
static NPObject* NPAllocate(NPP, NPClass*);
static void NPDeallocate(NPObject* npObj);
« no previous file with comments | « chrome/common/security_filter_peer.h ('k') | chrome/plugin/npobject_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698