Extensions: Move id_util functions to crx_file component.

Extensions: Move id_util functions to crx_file component.

Consolidates id_util functions of extension/app/component ids in the crx_file component.

It belongs there because these types of ids are not exclusive to extensions, but rather, for anything that comes in a crx file.

BUG=371463
TBR=blundell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290971

[tommycli, 2014-08-18 22:40:03]

yoz: PTAL. This patch has the move of all the extension id_util functions to the
crx_component, as we discussed last week.

Thanks!

[Yoyo Zhou, 2014-08-19 05:12:13]

LGTM

https://codereview.chromium.org/481433005/diff/80001/components/crx_file/id_u...
File components/crx_file/id_util.h (right):

https://codereview.chromium.org/481433005/diff/80001/components/crx_file/id_u...
components/crx_file/id_util.h:32: // Checks to see if the extension has a valid
ID.
This is not a good description. It checks an extension ID, not an extension.

[tommycli, 2014-08-19 16:48:57]

thestig: May I have a stamp on chrome/. Again, it's just a bunch of trivial
include and namespace changes...

rsleevi: May I have a stamp on adding crypto/ to components/crx_file/DEPS?

yoz: Thanks for review!

https://codereview.chromium.org/481433005/diff/80001/components/crx_file/id_u...
File components/crx_file/id_util.h (right):

https://codereview.chromium.org/481433005/diff/80001/components/crx_file/id_u...
components/crx_file/id_util.h:32: // Checks to see if the extension has a valid
ID.
On 2014/08/19 05:12:13, Yoyo Zhou wrote:
> This is not a good description. It checks an extension ID, not an extension.

Done.

[Ryan Sleevi, 2014-08-19 19:40:19]

rubberstamp LGTM for adding crypto/ DEPS

[Lei Zhang, 2014-08-19 21:13:24]

lgtm

https://codereview.chromium.org/481433005/diff/100001/chrome/browser/media_ga...
File chrome/browser/media_galleries/media_galleries_test_util.cc (right):

https://codereview.chromium.org/481433005/diff/100001/chrome/browser/media_ga...
chrome/browser/media_galleries/media_galleries_test_util.cc:71:
EXPECT_TRUE(extension.get() != NULL) << errors;
FYI, this likely needs to be an ASSERT_TRUE(), otherwise the test that uses this
utility function will crash on the next line.

[tommycli, 2014-08-19 21:38:57]

rsleevi, thestig: thanks!

https://codereview.chromium.org/481433005/diff/100001/chrome/browser/media_ga...
File chrome/browser/media_galleries/media_galleries_test_util.cc (right):

https://codereview.chromium.org/481433005/diff/100001/chrome/browser/media_ga...
chrome/browser/media_galleries/media_galleries_test_util.cc:71:
EXPECT_TRUE(extension.get() != NULL) << errors;
On 2014/08/19 21:13:24, Lei Zhang wrote:
> FYI, this likely needs to be an ASSERT_TRUE(), otherwise the test that uses
this
> utility function will crash on the next line.

Done.

[tommycli, 2014-08-19 21:39:31]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-08-19 21:40:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tommycli@chromium.org/481433005/120001

[commit-bot: I haz the power, 2014-08-19 22:56:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/43845)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/49013)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-19 23:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 23:03:13]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tommycli, 2014-08-20 18:02:32]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-08-20 18:03:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tommycli@chromium.org/481433005/140001

[commit-bot: I haz the power, 2014-08-20 20:02:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 20:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:55:20]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[tommycli, 2014-08-20 22:53:37]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:54:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tommycli@chromium.org/481433005/140001

[commit-bot: I haz the power, 2014-08-21 00:41:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 02:27:38]

Committed patchset #8 (140001) as 290971