chrome/renderer/extensions/webstore_bindings.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/webstore_bindings.cc

diff --git a/chrome/renderer/extensions/webstore_bindings.cc b/chrome/renderer/extensions/webstore_bindings.cc

index 2c2f06a2de7ebce71f4ead251523b63f8ebfc780..3a82d152e0e8f09616482fafea3f9b917add0e30 100644

--- a/chrome/renderer/extensions/webstore_bindings.cc

+++ b/chrome/renderer/extensions/webstore_bindings.cc

@@ -8,6 +8,7 @@

#include "chrome/common/extensions/api/webstore/webstore_api_constants.h"

#include "chrome/common/extensions/chrome_extension_messages.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "components/crx_file/id_util.h"

#include "content/public/renderer/render_view.h"

#include "extensions/common/extension.h"

#include "extensions/renderer/script_context.h"

@@ -165,7 +166,7 @@ bool WebstoreBindings::GetWebstoreItemIdFromFrame(

std::string candidate_webstore_item_id = webstore_url.path().substr(

webstore_base_url.path().length());

- if (!extensions::Extension::IdIsValid(candidate_webstore_item_id)) {

+ if (!crx_file::id_util::IdIsValid(candidate_webstore_item_id)) {

*error = kInvalidWebstoreItemUrlError;

return false;

}

« no previous file with comments | « chrome/renderer/DEPS ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »