chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index c82a41ea4e8a5580fe277895d8763ca66b69bfc1..085c1a872c98cccac573c04116f91f2667794b11 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -8,6 +8,7 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "chrome/common/extensions/manifest_url_handler.h"

+#include "components/crx_file/id_util.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -85,7 +86,7 @@ TEST_F(InitValueManifestTest, InitFromValueValid) {

PathService::Get(chrome::DIR_TEST_DATA, &path);

path = path.AppendASCII("extensions");

- EXPECT_TRUE(Extension::IdIsValid(extension->id()));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid(extension->id()));

EXPECT_EQ("1.0.0.0", extension->VersionString());

EXPECT_EQ("my extension", extension->name());

EXPECT_EQ(extension->name(), extension->short_name());

« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/common/pepper_permission_util_unittest.cc » ('j') | no next file with comments »