chrome/browser/extensions/webstore_installer.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 6bfa00f1d84e353e8cda552c84a63fcacf75b5fc..412be96807ed565dba1505b4be5f2a097911afdd 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -35,6 +35,7 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "components/crx_file/id_util.h"

#include "components/omaha_query_params/omaha_query_params.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/download_manager.h"

@@ -300,7 +301,7 @@ void WebstoreInstaller::Start() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

AddRef(); // Balanced in ReportSuccess and ReportFailure.

- if (!Extension::IdIsValid(id_)) {

+ if (!crx_file::id_util::IdIsValid(id_)) {

ReportFailure(kInvalidIdError, FAILURE_REASON_OTHER);

return;

}