chrome/browser/extensions/chrome_app_sorting_unittest.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_app_sorting_unittest.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/chrome_app_sorting_unittest.cc

diff --git a/chrome/browser/extensions/chrome_app_sorting_unittest.cc b/chrome/browser/extensions/chrome_app_sorting_unittest.cc

index 87f72f1988a5e0d4df4bf7211dc05f9a6628dacb..148e4f13ffa51a66e575a5168920d8d1c4e0cd7d 100644

--- a/chrome/browser/extensions/chrome_app_sorting_unittest.cc

+++ b/chrome/browser/extensions/chrome_app_sorting_unittest.cc

@@ -8,6 +8,7 @@

#include "chrome/browser/extensions/./extension_prefs_unittest.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "components/crx_file/id_util.h"

#include "extensions/common/manifest_constants.h"

#include "sync/api/string_ordinal.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -813,7 +814,7 @@ class ChromeAppSortingDefaultOrdinalsBase : public ChromeAppSortingTest {

prefs_.temp_dir().AppendASCII(name), Manifest::EXTERNAL_PREF,

simple_dict, Extension::NO_FLAGS, &errors);

EXPECT_TRUE(app.get()) << errors;

- EXPECT_TRUE(Extension::IdIsValid(app->id()));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid(app->id()));

return app;

}