chrome/browser/apps/ephemeral_app_throttle.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_throttle.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_throttle.cc

diff --git a/chrome/browser/apps/ephemeral_app_throttle.cc b/chrome/browser/apps/ephemeral_app_throttle.cc

index d4b04070ae1e34379846ebd7456c1984d48a4b9e..504e1b09d9e47299ffa279d8961d7cd4ccdea2e2 100644

--- a/chrome/browser/apps/ephemeral_app_throttle.cc

+++ b/chrome/browser/apps/ephemeral_app_throttle.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/profiles/profile_io_data.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "components/crx_file/id_util.h"

#include "components/navigation_interception/intercept_navigation_resource_throttle.h"

#include "components/navigation_interception/navigation_params.h"

#include "content/public/browser/browser_thread.h"

@@ -91,7 +92,7 @@ EphemeralAppThrottle::MaybeCreateThrottleForLaunch(

return NULL;

std::string app_id(request->url().ExtractFileName());

- if (!Extension::IdIsValid(app_id))

+ if (!crx_file::id_util::IdIsValid(app_id))

return NULL;

return new navigation_interception::InterceptNavigationResourceThrottle(

« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/apps/install_chrome_app.cc » ('j') | no next file with comments »