chrome/browser/extensions/extension_service_unittest.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index 20b589f095d6b57994d8962b2e59693cac3d18e0..cd2db75dc62fbbcadd5635dcd4eadb7a80f4aeaf 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -73,6 +73,7 @@

#include "chrome/common/url_constants.h"

#include "chrome/test/base/scoped_browser_locale.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/crx_file/id_util.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "content/public/browser/dom_storage_context.h"

#include "content/public/browser/gpu_data_manager.h"

@@ -4576,7 +4577,7 @@ TEST_F(ExtensionServiceTest, GenerateID) {

base::RunLoop().RunUntilIdle();

EXPECT_EQ(0u, GetErrors().size());

ASSERT_EQ(1u, loaded_.size());

- ASSERT_TRUE(Extension::IdIsValid(loaded_[0]->id()));

+ ASSERT_TRUE(crx_file::id_util::IdIsValid(loaded_[0]->id()));

EXPECT_EQ(loaded_[0]->location(), Manifest::UNPACKED);

ValidatePrefKeyCount(1);