chrome/browser/extensions/extension_function_test_utils.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_test_utils.cc

diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc

index 4cf8a32a52b384c1b77c51398c3660063165f8b8..03b4d7f9ef0c9a50cc8d8b6fae444aa6eae33114 100644

--- a/chrome/browser/extensions/extension_function_test_utils.cc

+++ b/chrome/browser/extensions/extension_function_test_utils.cc

@@ -13,11 +13,11 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "components/crx_file/id_util.h"

#include "extensions/browser/api_test_utils.h"

#include "extensions/browser/extension_function.h"

#include "extensions/browser/extension_function_dispatcher.h"

#include "extensions/common/extension.h"

-#include "extensions/common/id_util.h"

#include "testing/gtest/include/gtest/gtest.h"

using content::WebContents;

@@ -136,7 +136,7 @@ scoped_refptr<Extension> CreateExtension(

const base::FilePath test_extension_path;

std::string id;

if (!id_input.empty())

- id = extensions::id_util::GenerateId(id_input);

+ id = crx_file::id_util::GenerateId(id_input);

scoped_refptr<Extension> extension(Extension::Create(

test_extension_path,

location,