Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3866)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/webstore_bindings.cc ('k') | components/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index a9030b883666479f8d2ed5e0af252301deca9120..0af04e7dfb51974496353ebf9ab169f7ff85295d 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -15,8 +15,8 @@
#include "chrome/common/url_constants.h"
#include "chrome/grit/renderer_resources.h"
#include "chrome/renderer/searchbox/searchbox.h"
+#include "components/crx_file/id_util.h"
#include "content/public/renderer/render_view.h"
-#include "extensions/common/extension.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
@@ -849,7 +849,7 @@ void SearchBoxExtensionWrapper::GetThemeBackgroundInfo(
// theme.
// This is the CSS "background-image" format.
// Value is only valid if there's a custom theme background image.
- if (extensions::Extension::IdIsValid(theme_info.theme_id)) {
+ if (crx_file::id_util::IdIsValid(theme_info.theme_id)) {
info->Set(v8::String::NewFromUtf8(isolate, "imageUrl"),
UTF8ToV8String(isolate,
base::StringPrintf(kCSSBackgroundImageFormat,
« no previous file with comments | « chrome/renderer/extensions/webstore_bindings.cc ('k') | components/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698