extensions/browser/external_provider_interface.h - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/external_provider_interface.h

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/external_provider_interface.h

diff --git a/extensions/browser/external_provider_interface.h b/extensions/browser/external_provider_interface.h

index dd80e319f661767d6f3217d50f1064d745173d38..d14fc7c8ffd2e9f40456fd6b4d85571fe58ea71a 100644

--- a/extensions/browser/external_provider_interface.h

+++ b/extensions/browser/external_provider_interface.h

@@ -27,7 +27,8 @@ class ExternalProviderInterface {

// caller what extensions are registered, and which |id|, |version| and |path|

// they have. See also VisitRegisteredExtension below. Ownership of |version|

// is not transferred to the visitor. Callers of the methods below must

- // ensure that |id| is a valid extension id (use Extension::IdIsValid(id)).

+ // ensure that |id| is a valid extension id (use

+ // crx_file::id_util::IdIsValid(id)).

class VisitorInterface {

public:

// Return true if the extension install will proceed. Install will not

« no previous file with comments | « extensions/browser/extension_prefs.cc ('k') | extensions/browser/file_reader_unittest.cc » ('j') | no next file with comments »