Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: components/component_updater/component_updater_utils.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/BUILD.gn ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/component_updater/component_updater_utils.cc
diff --git a/components/component_updater/component_updater_utils.cc b/components/component_updater/component_updater_utils.cc
index 116a8d0c0286b2cfae7dc5b036942afd54184282..9ef561ebcf8593666ca4a1466eef8b0607df59d6 100644
--- a/components/component_updater/component_updater_utils.cc
+++ b/components/component_updater/component_updater_utils.cc
@@ -17,6 +17,7 @@
#include "base/win/windows_version.h"
#include "components/component_updater/component_updater_configurator.h"
#include "components/component_updater/crx_update_item.h"
+#include "components/crx_file/id_util.h"
#include "components/omaha_query_params/omaha_query_params.h"
#include "net/base/load_flags.h"
#include "net/url_request/url_fetcher.h"
@@ -181,8 +182,7 @@ std::string HexStringToID(const std::string& hexstr) {
}
}
- // TODO(tommycli): Add back the DCHECK validating the generated id. This
- // requires moving the extension id_util functions into components/crx_file.
+ DCHECK(crx_file::id_util::IdIsValid(id));
return id;
}
« no previous file with comments | « components/BUILD.gn ('k') | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698