chrome/common/extensions/extension_unittest.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_unittest.cc

diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc

index 04aea3bb89d93889340420095d2ff9013bcea03f..3e16817138caa22347aa57b9c83302bd5a468197 100644

--- a/chrome/common/extensions/extension_unittest.cc

+++ b/chrome/common/extensions/extension_unittest.cc

@@ -12,6 +12,7 @@

#include "chrome/common/extensions/extension_test_util.h"

#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"

#include "chrome/common/url_constants.h"

+#include "components/crx_file/id_util.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_resource.h"

#include "extensions/common/file_util.h"

@@ -184,15 +185,19 @@ TEST(ExtensionTest, GetAbsolutePathNoError) {

TEST(ExtensionTest, IdIsValid) {

- EXPECT_TRUE(Extension::IdIsValid("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));

- EXPECT_TRUE(Extension::IdIsValid("pppppppppppppppppppppppppppppppp"));

- EXPECT_TRUE(Extension::IdIsValid("abcdefghijklmnopabcdefghijklmnop"));

- EXPECT_TRUE(Extension::IdIsValid("ABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP"));

- EXPECT_FALSE(Extension::IdIsValid("abcdefghijklmnopabcdefghijklmno"));

- EXPECT_FALSE(Extension::IdIsValid("abcdefghijklmnopabcdefghijklmnopa"));

- EXPECT_FALSE(Extension::IdIsValid("0123456789abcdef0123456789abcdef"));

- EXPECT_FALSE(Extension::IdIsValid("abcdefghijklmnopabcdefghijklmnoq"));

- EXPECT_FALSE(Extension::IdIsValid("abcdefghijklmnopabcdefghijklmno0"));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid("pppppppppppppppppppppppppppppppp"));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid("abcdefghijklmnopabcdefghijklmnop"));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid("ABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP"));

+ EXPECT_FALSE(crx_file::id_util::IdIsValid("abcdefghijklmnopabcdefghijklmno"));

+ EXPECT_FALSE(

+ crx_file::id_util::IdIsValid("abcdefghijklmnopabcdefghijklmnopa"));

+ EXPECT_FALSE(

+ crx_file::id_util::IdIsValid("0123456789abcdef0123456789abcdef"));

+ EXPECT_FALSE(

+ crx_file::id_util::IdIsValid("abcdefghijklmnopabcdefghijklmnoq"));

+ EXPECT_FALSE(

+ crx_file::id_util::IdIsValid("abcdefghijklmnopabcdefghijklmno0"));

}

« no previous file with comments | « chrome/common/DEPS ('k') | chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc » ('j') | no next file with comments »