chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc ('k') | chrome/browser/extensions/chrome_app_sorting_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index addd6cacb6d882ed559f31efbdbf83c664e8c7b8..66915fe64be7e44c268fc47a218a7d48e4b1c261 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -36,6 +36,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/pref_names.h"

+#include "components/crx_file/id_util.h"

#include "components/signin/core/browser/signin_manager.h"

#include "components/signin/core/common/profile_management_switches.h"

#include "content/public/browser/gpu_data_manager.h"

@@ -237,7 +238,7 @@ bool WebstorePrivateBeginInstallWithManifest3Function::RunAsync() {

params_ = BeginInstallWithManifest3::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params_);

- if (!extensions::Extension::IdIsValid(params_->details.id)) {

+ if (!crx_file::id_util::IdIsValid(params_->details.id)) {

SetResultCode(INVALID_ID);

error_ = kInvalidIdError;

return false;

@@ -508,7 +509,7 @@ bool WebstorePrivateCompleteInstallFunction::RunAsync() {

scoped_ptr<CompleteInstall::Params> params(

CompleteInstall::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

- if (!extensions::Extension::IdIsValid(params->expected_id)) {

+ if (!crx_file::id_util::IdIsValid(params->expected_id)) {

error_ = kInvalidIdError;

return false;

}