chrome/browser/apps/install_chrome_app.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/install_chrome_app.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/install_chrome_app.cc

diff --git a/chrome/browser/apps/install_chrome_app.cc b/chrome/browser/apps/install_chrome_app.cc

index e433991e1a233fd059b79a800938020cbf08e63f..525f31eef5329828bae0d113aa8a5963b331e448 100644

--- a/chrome/browser/apps/install_chrome_app.cc

+++ b/chrome/browser/apps/install_chrome_app.cc

@@ -15,8 +15,8 @@

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/common/extensions/webstore_install_result.h"

+#include "components/crx_file/id_util.h"

#include "extensions/browser/extension_registry.h"

-#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

using extensions::ExtensionRegistry;

@@ -74,7 +74,7 @@ void WebstoreInstallWithPromptAppsOnly::OnManifestParsed() {

namespace install_chrome_app {

void InstallChromeApp(const std::string& app_id) {

- if (!extensions::Extension::IdIsValid(app_id))

+ if (!crx_file::id_util::IdIsValid(app_id))

return;

// At the moment InstallChromeApp() is called immediately after handling