extensions/common/manifest_handlers/externally_connectable.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/externally_connectable.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_handlers/externally_connectable.cc

diff --git a/extensions/common/manifest_handlers/externally_connectable.cc b/extensions/common/manifest_handlers/externally_connectable.cc

index 8fba3dba875a3eccfc59357c645a9f9de0dc6dd0..0a06c019ae2b375fb9c86ec71e205dbb7778b914 100644

--- a/extensions/common/manifest_handlers/externally_connectable.cc

+++ b/extensions/common/manifest_handlers/externally_connectable.cc

@@ -8,6 +8,7 @@

#include "base/stl_util.h"

#include "base/strings/utf_string_conversions.h"

+#include "components/crx_file/id_util.h"

#include "extensions/common/api/extensions_manifest_types.h"

#include "extensions/common/error_utils.h"

#include "extensions/common/manifest_constants.h"

@@ -172,7 +173,7 @@ scoped_ptr<ExternallyConnectableInfo> ExternallyConnectableInfo::FromValue(

++it) {

if (*it == kAllIds) {

all_ids = true;

- } else if (Extension::IdIsValid(*it)) {

+ } else if (crx_file::id_util::IdIsValid(*it)) {

ids.push_back(*it);

} else {

*error =