extensions/extensions.gyp - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index 64a1f3f8a4fb8c5789114aa360409a7e1bdeb798..295f70c5017a1f7df74db7b797f1e523ece1adbf 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -107,8 +107,6 @@

'common/features/simple_feature_filter.h',

'common/file_util.cc',

'common/file_util.h',

- 'common/id_util.cc',

- 'common/id_util.h',

'common/install_warning.cc',

'common/install_warning.h',

'common/manifest.cc',

@@ -886,7 +884,6 @@

'common/api/sockets/sockets_manifest_permission_unittest.cc',

'common/csp_validator_unittest.cc',

'common/event_filter_unittest.cc',

- 'common/id_util_unittest.cc',

'common/one_shot_event_unittest.cc',

'common/permissions/manifest_permission_set_unittest.cc',

'common/user_script_unittest.cc',