Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_test_util.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media_galleries/media_galleries_test_util.h" 5 #include "chrome/browser/media_galleries/media_galleries_test_util.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #endif 9 #endif
10 10
11 #include "base/base_paths.h" 11 #include "base/base_paths.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/files/file_path.h" 13 #include "base/files/file_path.h"
14 #include "base/path_service.h" 14 #include "base/path_service.h"
15 #include "base/strings/string_number_conversions.h" 15 #include "base/strings/string_number_conversions.h"
16 #include "base/strings/stringprintf.h" 16 #include "base/strings/stringprintf.h"
17 #include "chrome/browser/extensions/extension_service.h" 17 #include "chrome/browser/extensions/extension_service.h"
18 #include "chrome/browser/media_galleries/fileapi/picasa_finder.h" 18 #include "chrome/browser/media_galleries/fileapi/picasa_finder.h"
19 #include "chrome/browser/profiles/profile.h" 19 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/common/chrome_paths.h" 20 #include "chrome/common/chrome_paths.h"
21 #include "components/crx_file/id_util.h"
21 #include "extensions/browser/extension_prefs.h" 22 #include "extensions/browser/extension_prefs.h"
22 #include "extensions/browser/extension_system.h" 23 #include "extensions/browser/extension_system.h"
23 #include "extensions/common/extension.h"
24 #include "extensions/common/manifest_constants.h" 24 #include "extensions/common/manifest_constants.h"
25 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
26 26
27 #if defined(OS_MACOSX) 27 #if defined(OS_MACOSX)
28 #include "base/mac/foundation_util.h" 28 #include "base/mac/foundation_util.h"
29 #include "base/strings/sys_string_conversions.h" 29 #include "base/strings/sys_string_conversions.h"
30 #include "chrome/browser/media_galleries/fileapi/iapps_finder_impl.h" 30 #include "chrome/browser/media_galleries/fileapi/iapps_finder_impl.h"
31 #include "components/policy/core/common/preferences_mock_mac.h" 31 #include "components/policy/core/common/preferences_mock_mac.h"
32 #endif // OS_MACOSX 32 #endif // OS_MACOSX
33 33
(...skipping 28 matching lines...) Expand all
62 62
63 extensions::ExtensionPrefs* extension_prefs = 63 extensions::ExtensionPrefs* extension_prefs =
64 extensions::ExtensionPrefs::Get(profile); 64 extensions::ExtensionPrefs::Get(profile);
65 base::FilePath path = extension_prefs->install_directory().AppendASCII(name); 65 base::FilePath path = extension_prefs->install_directory().AppendASCII(name);
66 std::string errors; 66 std::string errors;
67 scoped_refptr<extensions::Extension> extension = 67 scoped_refptr<extensions::Extension> extension =
68 extensions::Extension::Create(path, extensions::Manifest::INTERNAL, 68 extensions::Extension::Create(path, extensions::Manifest::INTERNAL,
69 *manifest.get(), 69 *manifest.get(),
70 extensions::Extension::NO_FLAGS, &errors); 70 extensions::Extension::NO_FLAGS, &errors);
71 EXPECT_TRUE(extension.get() != NULL) << errors; 71 EXPECT_TRUE(extension.get() != NULL) << errors;
72 EXPECT_TRUE(extensions::Extension::IdIsValid(extension->id())); 72 EXPECT_TRUE(crx_file::id_util::IdIsValid(extension->id()));
73 if (!extension.get() || !extensions::Extension::IdIsValid(extension->id())) 73 if (!extension.get() || !crx_file::id_util::IdIsValid(extension->id()))
74 return NULL; 74 return NULL;
75 75
76 extension_prefs->OnExtensionInstalled( 76 extension_prefs->OnExtensionInstalled(
77 extension.get(), 77 extension.get(),
78 extensions::Extension::ENABLED, 78 extensions::Extension::ENABLED,
79 syncer::StringOrdinal::CreateInitialOrdinal(), 79 syncer::StringOrdinal::CreateInitialOrdinal(),
80 std::string()); 80 std::string());
81 ExtensionService* extension_service = 81 ExtensionService* extension_service =
82 extensions::ExtensionSystem::Get(profile)->extension_service(); 82 extensions::ExtensionSystem::Get(profile)->extension_service();
83 extension_service->AddExtension(extension.get()); 83 extension_service->AddExtension(extension.get());
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 base::FilePath MakeMediaGalleriesTestingPath(const std::string& dir) { 231 base::FilePath MakeMediaGalleriesTestingPath(const std::string& dir) {
232 #if defined(OS_WIN) 232 #if defined(OS_WIN)
233 return base::FilePath(FILE_PATH_LITERAL("C:\\")).AppendASCII(dir); 233 return base::FilePath(FILE_PATH_LITERAL("C:\\")).AppendASCII(dir);
234 #elif defined(OS_POSIX) 234 #elif defined(OS_POSIX)
235 return base::FilePath(FILE_PATH_LITERAL("/")).Append(dir); 235 return base::FilePath(FILE_PATH_LITERAL("/")).Append(dir);
236 #else 236 #else
237 NOTREACHED(); 237 NOTREACHED();
238 #endif 238 #endif
239 } 239 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698