chrome/browser/extensions/webstore_installer_unittest.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer_unittest.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer_unittest.cc

diff --git a/chrome/browser/extensions/webstore_installer_unittest.cc b/chrome/browser/extensions/webstore_installer_unittest.cc

index fbc48cbe14588c1b97bf5c83cc981a816226edfb..a686689a3f4627d99cfb32bed47ba9aebe05c262 100644

--- a/chrome/browser/extensions/webstore_installer_unittest.cc

+++ b/chrome/browser/extensions/webstore_installer_unittest.cc

@@ -7,8 +7,8 @@

#include "base/strings/stringprintf.h"

#include "chrome/browser/extensions/webstore_installer.h"

#include "chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h"

+#include "components/crx_file/id_util.h"

#include "components/omaha_query_params/omaha_query_params.h"

-#include "extensions/common/id_util.h"

#include "net/base/escape.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -23,7 +23,7 @@ bool Contains(const std::string& source, const std::string& target) {

}

TEST(WebstoreInstallerTest, PlatformParams) {

- std::string id = extensions::id_util::GenerateId("some random string");

+ std::string id = crx_file::id_util::GenerateId("some random string");

std::string source = "inline";

GURL url = WebstoreInstaller::GetWebstoreInstallURL(id,

WebstoreInstaller::INSTALL_SOURCE_INLINE);