apps/app_shim/extension_app_shim_handler_mac.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_shim/extension_app_shim_handler_mac.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/app_shim/extension_app_shim_handler_mac.cc

diff --git a/apps/app_shim/extension_app_shim_handler_mac.cc b/apps/app_shim/extension_app_shim_handler_mac.cc

index cef6ca2d3a6c4fdf1c312c177df502224b92aefc..c13d73cc000c92b99c599f03cbfe58c84c37e7b6 100644

--- a/apps/app_shim/extension_app_shim_handler_mac.cc

+++ b/apps/app_shim/extension_app_shim_handler_mac.cc

@@ -22,6 +22,7 @@

#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"

#include "chrome/browser/web_applications/web_app_mac.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "components/crx_file/id_util.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

@@ -302,7 +303,7 @@ void ExtensionAppShimHandler::OnShimLaunch(

AppShimLaunchType launch_type,

const std::vector<base::FilePath>& files) {

const std::string& app_id = host->GetAppId();

- DCHECK(extensions::Extension::IdIsValid(app_id));

+ DCHECK(crx_file::id_util::IdIsValid(app_id));

const base::FilePath& profile_path = host->GetProfilePath();

DCHECK(!profile_path.empty());

« no previous file with comments | « apps/app_shim/DEPS ('k') | chrome/browser/DEPS » ('j') | no next file with comments »